[webkit-reviews] review granted: [Bug 65899] A mouseover/mouseout event is not dispatched when a mouse moves from a direct child node of shadow root into a sibling node : [Attachment 103607] WIP

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 65899: A mouseover/mouseout event is not dispatched when a mouse moves from
a direct child node of shadow root into a sibling node
https://bugs.webkit.org/show_bug.cgi?id=65899

Attachment 103607: WIP
https://bugs.webkit.org/attachment.cgi?id=103607&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103607&action=review


> LayoutTests/fast/dom/shadow/shadow-boundary-events.html:51
> +    //   eventRecores[eventType] =
['target.id(@currentTarget.id)(<-relatedTarget.id)',
'target.id(@currentTarget.id)(<-relatedTarget.id)', ...]

eventRecores -> eventRecords

> LayoutTests/fast/dom/shadow/shadow-boundary-events.html:118
> +		 'Move mouse from a node to its sibling node. Every nodes are
outside of shadow boundary.');
> +    shouldBe('dispatchedEvent("mouseover")', '["div2(@div2)(<-div1)",
"div2(@divA)(<-div1)"]');
> +    shouldBe('dispatchedEvent("mouseout")', '["div1(@div1)(<-div2)",
"div1(@divA)(<-div2)"]');

I like this format! It's much easier to understand.

> LayoutTests/fast/dom/shadow/shadow-boundary-events.html:121
> +		 'Target is an ancestor of realtedTarget. Every nodes are
outside of shadow boundary.');

realtedTarget -> relatedTarget, Every -> All (here and elsewhere)

> LayoutTests/fast/dom/shadow/shadow-boundary-events.html:131
> +		 'Both target and relatedTarget are direct child of the same
shadow root.');

direct->immediate, child->children

> LayoutTests/fast/dom/shadow/shadow-boundary-events.html:166
> +		 'Target and relatedTarget exist in separated subtree, crossing
shadow boundaries. Making sure that event is not dispatched beyond the lowest
command bandary.');

command bandary->common boundary