[webkit-reviews] review denied: [Bug 66050] Web Inspector: Resources panel: display the current search match index in the toolbar. : [Attachment 103613] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 66050: Web Inspector: Resources panel: display the current search match
index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66050

Attachment 103613: Patch
https://bugs.webkit.org/attachment.cgi?id=103613&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103613&action=review


Too much logic here, please provide a test.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1632
> +	       return
this._searchResult(this._traverser.next(currentTreeElement), 0,
this._currentMatchIndex % this._matchesCount + 1);

Why % ? Shouldn't _currentMatchIndex be normalized on its own?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1650
> +		   return this._searchResult(treeElement,
treeElement.searchMatchesCount - 1, currentMatchIndex);

I think this requires a test!