[webkit-reviews] review granted: [Bug 65975] [Qt/WK2] Add initial support for viewport meta tag : [Attachment 103616] Patch 3

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 65975: [Qt/WK2] Add initial support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=65975

Attachment 103616: Patch 3
https://bugs.webkit.org/attachment.cgi?id=103616&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103616&action=review


Simple, clean...awesome :)

> Source/WebKit2/UIProcess/API/qt/qtouchwebview_p.h:63
> +
> +    WebCore::ViewportArguments viewportArguments;

Could be private I guess but that does not help much.

> Source/WebKit2/UIProcess/qt/TouchViewInterface.cpp:28
> +#include <WebCore/ViewportArguments.h>

I think you can get away with forward declaration.

> Source/WebKit2/UIProcess/qt/TouchViewInterface.h:25
> +#include <WebCore/ViewportArguments.h>

You have a forward declaration in ViewInterface.