[webkit-reviews] review denied: [Bug 65986] [Qt] autotests shouldn't require config.h in the style check : [Attachment 103596] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 65986: [Qt] autotests shouldn't require config.h in the style check
https://bugs.webkit.org/show_bug.cgi?id=65986

Attachment 103596: Patch
https://bugs.webkit.org/attachment.cgi?id=103596&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103596&action=review


You must also modify the tests accordingly. And you should add a new test for
Source/WebKit/qt/tests/MIMESniffing.

> Tools/Scripts/webkitpy/style/checker.py:137
> +    ([# The MIMESniffing test tests the code directly rather than the API,
> +	 # let's enable the include check for this one.
> +	 "Source/WebKit/qt/tests/MIMESniffing"],
> +	["+build/include"]),

This list is order sensitive. Only the first path substring match is used. ->
Source/WebKit/qt/tests/MIMESniffing will never match