[webkit-reviews] review denied: [Bug 65965] Implement internals.computedStyleIncludingVisitedInfo() : [Attachment 103453] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Kentaro Hara
<haraken at google.com>'s request for review:
Bug 65965: Implement internals.computedStyleIncludingVisitedInfo()
https://bugs.webkit.org/show_bug.cgi?id=65965

Attachment 103453: Patch
https://bugs.webkit.org/attachment.cgi?id=103453&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103453&action=review


> ChangeLog:8
> +	   - Implemented internals.computedStyleIncludingVisitedInfo(), which
can be used by all platforms.

This should be at Source/WebCore/ChangeLog

> ChangeLog:9
> +	   - Replaced layoutTestController.computedStyleIncludingVisitedInfo()
in tests

This should be at LayoutTests/ChangeLog

> ChangeLog:12
> +	   platform-dependent codes.

This should be at each of Source/WebKit/*/ChangeLog

> LayoutTests/ChangeLog:2
> +

Ditto.

> LayoutTests/fast/history/multiple-classes-visited.html:11
> +    var firstStyle =
window.internals.computedStyleIncludingVisitedInfo(document.getElementById('one
'));

Need to check window.internals to make the test runnable outside DRT.

> LayoutTests/fast/history/nested-visited-test.html:-17
> -    if (window.layoutTestController) {

Need to check window.internals to make the test runnable outside DRT.

> LayoutTests/fast/history/nested-visited-test.html:-50
> -<script>

Don't touch unrelated code if possible.

> LayoutTests/fast/history/self-is-visited.html:-11
> -    if (window.layoutTestController) {

Ditto.

> LayoutTests/fast/history/sibling-visited-test.html:-11
> -    if (window.layoutTestController) {

Ditto.

> LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited.html:-13
> -    if (window.layoutTestController) {

Ditto.