[webkit-reviews] review denied: [Bug 66004] Remove ifdefs for CSS exclusions and CSS regions : [Attachment 103519] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 10 13:01:36 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has denied Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 66004: Remove ifdefs for CSS exclusions and CSS regions
https://bugs.webkit.org/show_bug.cgi?id=66004

Attachment 103519: Patch
https://bugs.webkit.org/attachment.cgi?id=103519&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
There are other FeatureDefines.xcconfig files that need to be modified (in
places like Source/WebKit2/Configurations, e.g.). And you need to modify
WebKitLibraries/win/tools/vsprops/FeatureDefines.*. And maybe other places for
other ports, too. And you'll need to modify build-webkit to remove the
Regions-related flags, and the files in
Tools/BuildSlaveSupport/build.webkit.org-config that control how the CSSRegions
bot operates.


More information about the webkit-reviews mailing list