[webkit-reviews] review denied: [Bug 65869] JSC should always throw when function arg list is too long : [Attachment 103508] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 10 11:36:16 PDT 2011


Oliver Hunt <oliver at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 65869: JSC should always throw when function arg list is too long
https://bugs.webkit.org/show_bug.cgi?id=65869

Attachment 103508: Patch
https://bugs.webkit.org/attachment.cgi?id=103508&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I think it would be ebtter to just use createStackoverflow (or whatever the
function is called) because that's kind of what we're pretending the issue is.

Also you should probably test the behaviour of

function test() { print(arguments.length); }
function f() {
    test.apply(null, arguments);
}
f(0,0,0,0,0,0,0,0,...<70000 arguments>)

As the jit inlines apply(..., arguments)


More information about the webkit-reviews mailing list