[webkit-reviews] review granted: [Bug 65903] [Chromium] Implement text shaping with font-feature-settings on Linux : [Attachment 103444] Patch V2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 10 10:18:57 PDT 2011


Adam Barth <abarth at webkit.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 65903: [Chromium] Implement text shaping with font-feature-settings on
Linux
https://bugs.webkit.org/show_bug.cgi?id=65903

Attachment 103444: Patch V2
https://bugs.webkit.org/attachment.cgi?id=103444&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103444&action=review


The harfbuzz code is a mystery to me, but I believe that evmar knows that he's
talking about.	:)

>> Source/WebCore/platform/graphics/Font.cpp:274
>> +	if (m_fontDescription.featureSettings() &&
m_fontDescription.featureSettings()->size() > 0)
>> +	    return Complex;
> 
> One more question: this change here affects all WebKit ports.  Will it be a
problem for the other ports?
> 
> I guess .featureSettings() is only available when the page uses these new CSS
keywords, which should be very rare, right?

I'm not an expert here, but this seems ok to me.  -webkit-font-feature-settings
kicking us into complex mode shouldn't be too much of a problem.


More information about the webkit-reviews mailing list