[webkit-reviews] review denied: [Bug 65925] MediaStream API: add createObjectURL functionality : [Attachment 103488] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 65925: MediaStream API: add createObjectURL functionality
https://bugs.webkit.org/show_bug.cgi?id=65925

Attachment 103488: Patch
https://bugs.webkit.org/attachment.cgi?id=103488&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103488&action=review


> LayoutTests/fast/files/create-blob-url-crash-expected.txt:2
> -PASS: Not enough arguments
> +PASS: Type error

IMHO, we shouldn't change this behavior.  We probably need to fix the code
generator to generate correct code.

> Source/WebCore/ChangeLog:7
> +	   MediaStream API: add createObjectURL functionality
> +	   https://bugs.webkit.org/show_bug.cgi?id=65925
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

This ChangeLog doesn't explain why we're making this change or why this patch
doesn't contain tests.	Is there some reason we can't test this patch?

> Source/WebCore/dom/ScriptExecutionContext.cpp:396
> +    publicURL.setProtocol("x-raw-media");

http://groups.google.com/a/chromium.org/group/chromium-reviews/browse_thread/th
read/c31593de00fba166?hide_quotes=no&fwc=2&pli=1 is the only reference to
x-raw-media I can find on the Internet.  We shouldn't be making up URL schemes,
especially ones that are visible externally.