[webkit-reviews] review denied: [Bug 65875] [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method : [Attachment 103419] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 65875: [Qt][WK2] MiniBrowser is firing twice the
QDesktopWebView::mousePressEvent method
https://bugs.webkit.org/show_bug.cgi?id=65875

Attachment 103419: Patch
https://bugs.webkit.org/attachment.cgi?id=103419&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103419&action=review


This has nothing to do with the ControlModifier. The problem is we still send
the original mouse event after we send the touch events. QWidget also generate
a fake mouse event for the touch event so we end up with 2 mouse events. The
original event should be discarded when a touch event is generated.

> Tools/ChangeLog:9
> +	   On some windowing systems, mouse events are also sent for the
primary touch point. This
> +	   means it is possible for your widget to receive both QTouchEvent and
QMouseEvent for the
> +	   same user interaction point. MiniBrowser when setting the
Qt::TouchPointPressed for a touch

Qt is supposed to always give you a mouse event for the primary touch point.

> Tools/ChangeLog:12
> +	   to be called twice for a single mouse click. Now the
Qt::TouchPointPressed is used just
> +	   when Ctrl modifier is pressed.

This is not at all the intended behavior of the code of touch mocking.