[webkit-reviews] review granted: [Bug 65701] Web Inspector: auto-completion for string literals doesn't work : [Attachment 103459] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 10 06:08:19 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 65701: Web Inspector: auto-completion for string literals doesn't work
https://bugs.webkit.org/show_bug.cgi?id=65701

Attachment 103459: Patch
https://bugs.webkit.org/attachment.cgi?id=103459&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103459&action=review


> Source/WebCore/inspector/front-end/ConsoleView.js:427
> +	       function getCompletions(primitiveType)

This must be left as
 var getCompletions = function...
to avoid cluttering inspected global scope with our named functions.


More information about the webkit-reviews mailing list