[webkit-reviews] review requested: [Bug 27238] Animated GIF dynamically removed and readded to page does not re-animate : [Attachment 103461] Added resetAnimation() fuction call in order to restart animation

[bugzilla-daemon at webkit.org]

Swapna P <vswap65 at gmail.com> has asked	for review:
Bug 27238: Animated GIF dynamically removed and readded to page does not
re-animate
https://bugs.webkit.org/show_bug.cgi?id=27238

Attachment 103461: Added resetAnimation() fuction call in order to restart
animation 
https://bugs.webkit.org/attachment.cgi?id=103461&action=review

------- Additional Comments from Swapna P <vswap65 at gmail.com>
For each click, it is creating one pair of instances of HTMLImageElement &
RenderImage but they all share the same BitmapImage instance for animation.

For the first click of play button , image is getting animated. If we click for
2nd time, it again calls for BitmapImage::startAnimation() but because the
animation is currently continuing, the function just returns without doing
anything. But the expected behavior is that for each click, all the existing
image animations has to be restarted as IE/FF does.

So, therefore we need to somehow call resetAnimation() for the above behavior
in each button click & that's why when the new image being appended, we are
calling resetAnimation().

I have thought about all the corner cases to make sure that this change will
not have any side effect. Please let me know your opinion.

I have not yet added the test case for this. If the code changes are fine, I
will add the test case & upload a final patch.