[webkit-reviews] review granted: [Bug 65967] WebSocket: Add binaryType attribute : [Attachment 103449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 10 01:04:42 PDT 2011


Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 65967: WebSocket: Add binaryType attribute
https://bugs.webkit.org/show_bug.cgi?id=65967

Attachment 103449: Patch
https://bugs.webkit.org/attachment.cgi?id=103449&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103449&action=review


> Source/WebCore/websockets/WebSocket.cpp:223
> +    if (m_binaryType == BinaryTypeBlob)
> +	   return "blob";
> +    if (m_binaryType == BinaryTypeArrayBuffer)
> +	   return "arraybuffer";

We had better use switch-case.


More information about the webkit-reviews mailing list