[webkit-reviews] review granted: [Bug 65883] DFG JIT has no way of propagating predictions to loads and calls : [Attachment 103306] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 9 16:48:05 PDT 2011


Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 65883: DFG JIT has no way of propagating predictions to loads and calls
https://bugs.webkit.org/show_bug.cgi?id=65883

Attachment 103306: the patch
https://bugs.webkit.org/attachment.cgi?id=103306&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103306&action=review


Sorry to cq- for a typo, but I think there is a grammar error in the change
log. :-)
Otherwise all looks good.  I think we might want a prediction for more (all)
node types in the future, so may want to break this out as a separate field,
but reuse of opInfo2 seems like a good call, at least for now.

> Source/JavaScriptCore/ChangeLog:8
> +	   This introduces the capability to stored predictions on graph

stored -> store ?


More information about the webkit-reviews mailing list