[webkit-reviews] review denied: [Bug 62191] [Qt] Creating webkit2 popup menu hooks and adding popup menus to MiniBrowser. : [Attachment 103369] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 62191: [Qt] Creating webkit2 popup menu hooks and adding popup menus to
MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=62191

Attachment 103369: Patch
https://bugs.webkit.org/attachment.cgi?id=103369&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103369&action=review


> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:71
> +    void setCreateNewPopupMenuFunction(QWKPopupMenuFactory*, void* data);
> +    QWKPopupMenu* createPopupMenu(const QWKPopupMenuData*,
QWKPopupMenuClient*);
> +

No no no no no no
The whole idea is to have a simple component you integrate into QML and provide
everything you need.
Especially in the current public views, which are supposed to be simplified as
much as possible.

QWKPopupMenu -> We have dropped the "WK" prefix in trunk.

If it is required to have a popup menu exposed in the views, then this needs to
be hidden by an other in QML. Ideally, if the feature is implemented correct,
you would have it working without making any change to MiniBrowser.