[webkit-reviews] review granted: [Bug 65907] [Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap : [Attachment 103344] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 65907: [Qt] Vastly improve the algorithm for finding a zoomable area when
doing double-tap
https://bugs.webkit.org/show_bug.cgi?id=65907

Attachment 103344: Patch
https://bugs.webkit.org/attachment.cgi?id=103344&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103344&action=review


r=me

Two comments though. First, I think if we keep this as public API, we should
rework it to have proper request/response mapping (though the point/rect
mapping that this patch introduces is certainly better than what we had
before.) I don't believe this mechanism should be public though, as it could be
completely handled by the respective views.

Second, after this patch, a FindZoomableAreaForPoint request can now yield no
response whatsoever. Given how the "end-user signal" is used, I don't see a
problem with it, and I'm assuming this is intentional. Just making a note here
in case it wasn't.

> Source/WebKit2/ChangeLog:12
> +
> +

Double newline yo.