[webkit-reviews] review requested: [Bug 64151] [skia] turn off bitmap filtering for RESAMPLE_NONE : [Attachment 103202] Patch

[bugzilla-daemon at webkit.org]

Mike Lawther <mikelawther at chromium.org> has asked  for review:
Bug 64151: [skia] turn off bitmap filtering for RESAMPLE_NONE
https://bugs.webkit.org/show_bug.cgi?id=64151

Attachment 103202: Patch
https://bugs.webkit.org/attachment.cgi?id=103202&action=review

------- Additional Comments from Mike Lawther <mikelawther at chromium.org>
Yes. In some cases, it's only part of the image that has used nearest-neighbor.
 For example, in fast/borders/border-image-01.html, only the border images that
are stretched a lot in one dimension are NN, the central image is still linear.


This seems like an intended effect of computeResamplingMode, eg

  // Don't resample if it is being stretched a lot in only one direction. 
  // This is trying to catch cases where somebody has created a border
  // (which might be large) and then is stretching it to fill some part
  // of the page.

All of these heuristics that returned RESAMPLE_NONE are currently not being
acted on, so if they are wrong, or no longer desired, then they really should
be deleted. I can do that in another patch.

btw - the cr-linux bot passed the patch (looks like it was a unrelated
failure), so I'm adding the review flag back.