[webkit-reviews] review denied: [Bug 65399] StackBounds checker fails on custom stack implementations (typically in a coroutine setting) : [Attachment 102539] Proposed patch v2 (fixed more style errors, moved export to private header)

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Slava Akhmechet
<coffeemug at gmail.com>'s request for review:
Bug 65399: StackBounds checker fails on custom stack implementations (typically
in a coroutine setting)
https://bugs.webkit.org/show_bug.cgi?id=65399

Attachment 102539: Proposed patch v2 (fixed more style errors, moved export to
private header)
https://bugs.webkit.org/attachment.cgi?id=102539&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102539&action=review


> Source/JavaScriptCore/API/JSContextRef.cpp:67
> +void JSSetStackBounds(JSContextGroupRef group, void* origin, void* bound)

Our namespacing convention calls for "JSContextGroupSetStackBounds".

> Source/JavaScriptCore/runtime/JSGlobalData.cpp:210
>	   m_stack = wtfThreadData().stack();
> +    else
> +	   m_stack = new StackBounds();

This doesn't seem right. For globalDataType != Default, m_stack gets set to
"new StackBounds()", but stack() returns wtfThreadData().stack().