[webkit-reviews] review denied: [Bug 65875] [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method : [Attachment 103291] Patch.

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 65875: [Qt][WK2] MiniBrowser is firing twice the
QDesktopWebView::mousePressEvent method
https://bugs.webkit.org/show_bug.cgi?id=65875

Attachment 103291: Patch.
https://bugs.webkit.org/attachment.cgi?id=103291&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103291&action=review


> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:107
>	       if (m_touchPoints.contains(touchPoint.id()))
>		   touchPoint.setState(Qt::TouchPointMoved);
> -	       else
> -		   touchPoint.setState(Qt::TouchPointPressed);
> +	       else {
> +		   if (mouseEvent->modifiers().testFlag(Qt::ControlModifier))
> +		       touchPoint.setState(Qt::TouchPointPressed);
> +	       }

It seems to me that the problem might be that
m_touchPoints.contains(touchPoint.id()) == false.
If the touchpoint is still active because, it should be in m_touchPoints.