[webkit-reviews] review granted: [Bug 65708] Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState : [Attachment 103294] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 65708: Logic to compute visible display rect in
GraphicsLayerCA::syncCompositingState
https://bugs.webkit.org/show_bug.cgi?id=65708

Attachment 103294: Patch
https://bugs.webkit.org/attachment.cgi?id=103294&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103294&action=review


r=me but please do the localState thing.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:831
> -void GraphicsLayerCA::recursiveCommitChanges(float pageScaleFactor, const
FloatPoint& positionRelativeToBase, bool affectedByPageScale)
> +void GraphicsLayerCA::recursiveCommitChanges(TransformState& state, float
pageScaleFactor, const FloatPoint& positionRelativeToBase, bool
affectedByPageScale)
>  {
> +    // Save the state before sending down to kids and restore it after
> +    TransformState savedTransformState = state;

The more natural way to do this would be to have

TransformState localState = state;
and pass localState to kids.

Then your TransformState& param can be const.