[webkit-reviews] review requested: [Bug 65871] Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup : [Attachment 103284] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 8 13:30:30 PDT 2011


Chiculita Alexandru <achicu at adobe.com> has asked  for review:
Bug 65871: Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating
elements lookup
https://bugs.webkit.org/show_bug.cgi?id=65871

Attachment 103284: Patch
https://bugs.webkit.org/attachment.cgi?id=103284&action=review

------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
"positionNewFloatOnLine" is moving the object, so it had to remove it from the
tree, move it and add it back in the tree. "removePlacedObject" also sets the
isPlaced to false, so the call to x() or y() would assert about isPlaced being
false. Now I saved the old position on stack before calling removePlacedObject,
so that the assert is avoided.


More information about the webkit-reviews mailing list