[webkit-reviews] review granted: [Bug 65794] Wire up updating expectations in garden-o-matic. : [Attachment 103276] Better.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 65794: Wire up updating expectations in garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=65794

Attachment 103276: Better.
https://bugs.webkit.org/attachment.cgi?id=103276&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103276&action=review


> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:59
> +	       expectation_set = set([expectation for expectation in
map(TestExpectations.expectation_from_string, failure_info['failureTypeList'])
if expectation])

This looks like just map + filter.

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:63
> +	       editor.update_expectation(failure_info['testName'],
set([self._builder_to_test_config(failure_info['builderName'])]),
expectation_set)

failure_info['testName'] -> test_name

> Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:55
> +    @classmethod
> +    def path_to_test_expectations_file(cls):
> +	   if not cls._path_to_test_expectations_file:
> +	       cls._path_to_test_expectations_file =
cls.create().path_to_test_expectations_file()
> +	   return cls._path_to_test_expectations_file

This looks like a manual memoize.  Does this really need to be cached?	How
much does it slow down the test not to be cached?