[webkit-reviews] review granted: [Bug 65784] Web Inspector: Network panel always displays file:// resources as "(pending)" : [Attachment 103239] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 8 10:05:55 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 65784: Web Inspector: Network panel always displays file:// resources as
"(pending)"
https://bugs.webkit.org/show_bug.cgi?id=65784

Attachment 103239: patch
https://bugs.webkit.org/attachment.cgi?id=103239&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103239&action=review


> LayoutTests/inspector/network-status-non-http.html:5
> +test = function() {

function test() {

> LayoutTests/inspector/network-status-non-http.html:14
> +	   var dataGrid = logView.element.querySelector("table.data");

what is dataGrid.textContent ?

> LayoutTests/inspector/network-status-non-http.html:44
> +function addElement(src)

addScriptElement

> LayoutTests/inspector/network-status-non-http.html:48
> +    document.body.appendChild(element);

document.head.appendChild


More information about the webkit-reviews mailing list