[webkit-reviews] review denied: [Bug 64879] [Qt] Implement WebGL antialiasing (part 3) : [Attachment 103248] implement antialiasing

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 64879: [Qt] Implement WebGL antialiasing (part 3)
https://bugs.webkit.org/show_bug.cgi?id=64879

Attachment 103248: implement antialiasing
https://bugs.webkit.org/attachment.cgi?id=103248&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103248&action=review


Almost there.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:143
> +    if (m_context->m_attrs.antialias)

This should be an early return inside
blitMultisampleFramebufferAndRestoreContext

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:209
> +    if (m_context->m_attrs.antialias)

This should be an early return inside blitMultisampleFramebuffer

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:348
> +	   // Bind canvas FBO

Period at end of sentence :)