[webkit-reviews] review requested: [Bug 64879] [Qt] Implement WebGL antialiasing (part 3) : [Attachment 103248] implement antialiasing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 8 08:24:37 PDT 2011


Andrew Wason <rectalogic at rectalogic.com> has asked  for review:
Bug 64879: [Qt] Implement WebGL antialiasing (part 3)
https://bugs.webkit.org/show_bug.cgi?id=64879

Attachment 103248: implement antialiasing
https://bugs.webkit.org/attachment.cgi?id=103248&action=review

------- Additional Comments from Andrew Wason <rectalogic at rectalogic.com>
> This is becoming rather unreadable... can we refactor to use early returns?
> Looks to me that with early returns this can shrink to a single condition
level from 3.

I refactored, but I kept the 2nd condition level for deleting
m_multisampleDepthStencilBuffer, it looked more confusing using an early return
for that.


More information about the webkit-reviews mailing list