[webkit-reviews] review denied: [Bug 65830] DFG JIT verbose mode does not report the generated types of nodes : [Attachment 103187] the patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Filip Pizlo <fpizlo at apple.com>'s request
for review:
Bug 65830: DFG JIT verbose mode does not report the generated types of nodes
https://bugs.webkit.org/show_bug.cgi?id=65830

Attachment 103187: the patch
https://bugs.webkit.org/attachment.cgi?id=103187&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103187&action=review


> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1300
>	   if (!m_compileOkay)
>	       return;
> +#if DFG_DEBUG_VERBOSE
> +	   if (node.hasResult())
> +	       fprintf(stderr, "-> %s\n",
dataFormatToString(m_generationInfo[node.virtualRegister()].registerFormat()));

> +	   else
> +	       fprintf(stderr, "\n");
> +#endif

It seems like this might give output without a newline in the case that the
compile fails.