[webkit-reviews] review granted: [Bug 65817] move FrameLoadRequest to loader/ : [Attachment 103164] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted jochen at chromium.org's request
for review:
Bug 65817: move FrameLoadRequest to loader/
https://bugs.webkit.org/show_bug.cgi?id=65817

Attachment 103164: Patch
https://bugs.webkit.org/attachment.cgi?id=103164&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103164&action=review


I'm not the best person to judge what goes into page, and what goes into loader
directory. Since Darin and Adam had a look at the bug, I feel confident enough
to say r=me now.

> LoadRequest will be a wrapper around ResourceRequst that knows about
TargetType

It really helps that you explain your next steps as you go. The plan looks good
to me so far, but I expect some discussion about division of responsibility
between LoadRequest and ResourceLoader to take place soon.

> Source/WebCore/loader/FrameLoadRequest.h:36
> +    explicit FrameLoadRequest(PassRefPtr<SecurityOrigin> requester)

I'm not sure if we reached consensus in a webkit-dev discussion a few months
ago, but I think that this is a misuse of PassRefPtr, and a plain pointer
should be used.

Of course, this should not be changed in this patch, which only moves a file.