[webkit-reviews] review granted: [Bug 65809] Move the shared LineBreakIteratorPool from ThreadGlobalData into its own ThreadSpecific : [Attachment 103145] Remove ThreadGlobalData::lineBreakIteratorPool() and implement LineBreakIteratorPool::shared() using ThreadSpecific

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 65809: Move the shared LineBreakIteratorPool from ThreadGlobalData into its
own ThreadSpecific
https://bugs.webkit.org/show_bug.cgi?id=65809

Attachment 103145: Remove ThreadGlobalData::lineBreakIteratorPool() and
implement LineBreakIteratorPool::shared() using ThreadSpecific
https://bugs.webkit.org/attachment.cgi?id=103145&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103145&action=review


> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:92
> +    static WTF::ThreadSpecific<LineBreakIteratorPool>* staticPool;

Since this is used only in one function it could be a static local to the
function rather than a static data member. If it was, the function would not
need an explicit check for null and we also would have no need for
LineBreakIteratorPoolICU.cpp.