[webkit-reviews] review requested: [Bug 61042] [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests : [Attachment 103147] Following kling's advices, and solving some issues around comparison of bitmaps in this test.

[bugzilla-daemon at webkit.org]

Rafael Brandao <rafael.lobo at openbossa.org> has asked  for review:
Bug 61042: [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav()
autotests
https://bugs.webkit.org/show_bug.cgi?id=61042

Attachment 103147: Following kling's advices, and solving some issues around
comparison of bitmaps in this test.
https://bugs.webkit.org/attachment.cgi?id=103147&action=review

------- Additional Comments from Rafael Brandao <rafael.lobo at openbossa.org>
According to Qt doc, instead of "qrc://", for a QDir you must use ":/". As
QPixmap was expecting a file path, it wouldn't resolve the file with the url
format. As the icon and this not retrieved image were both empty QPixmaps, the
test was presenting a false positive.

For the issues around QActions on historyNav() test case, there is a small
patch pending for review on https://bugs.webkit.org/show_bug.cgi?id=64989 with
a quick solution. If anyone else wants to investigate those errors, go ahead.
:)