[webkit-reviews] review granted: [Bug 64974] REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe) : [Attachment 103049] Patch v7

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 64974: REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical
glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974

Attachment 103049: Patch v7
https://bugs.webkit.org/attachment.cgi?id=103049&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
r=me with the following comments:

View in context: https://bugs.webkit.org/attachment.cgi?id=103049&action=review


> Source/WebCore/ChangeLog:11
> +	   Fix host <-> embedded document size negotiation race. The current
implemented solution relied on a specific

typo: currently

> Source/WebCore/ChangeLog:12
> +	   order of paint/layout calls, which is broken. Consider rendering a
document containing a object/iframe/embed

typo: an

> Source/WebCore/page/FrameView.cpp:1100
> +    forceLayoutParentViewIfNeeded();

Inline function definition should precede the usage.

> Source/WebCore/page/FrameView.cpp:1122
> +inline void FrameView::forceLayoutParentViewIfNeeded()

Please move this function before the usage.