[webkit-reviews] review granted: [Bug 65645] Scroll animator changes to nail the framerate : [Attachment 103111] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Scott Byer
<scottbyer at chromium.org>'s request for review:
Bug 65645: Scroll animator changes to nail the framerate
https://bugs.webkit.org/show_bug.cgi?id=65645

Attachment 103111: Patch
https://bugs.webkit.org/attachment.cgi?id=103111&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103111&action=review


R=me, one nit.	You don't have to upload another patch for review, just upload
a new patch that has "Reviewed by James Robinson." in the ChangeLogs instead of
NOBODY (OOPS!) and mark the patch cq? but not review? and any committer can
flag it for review. I've come down with some sort of illness so I might not be
able to get back to this soon.

> Source/WebCore/platform/ScrollAnimatorNone.cpp:318
> +    bool result = data.updateDataFromParameters(orientation, step,
multiplier, scrollableSize, WTF::monotonicallyIncreasingTime(), &parameters);

nitpick: "result" is not very illuminating.  what does it mean when
updateDataFromParameters() returns false?  was there some problem with the
input parameters, or internal error in the calculations? did the scroll happen
or not?  I'd suggest renaming this variable to describe what it means.