[webkit-reviews] review granted: [Bug 33247] Upwards cursor movement incorrect when previous block ends with <br> : [Attachment 103120] rebaselined the test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 5 16:27:04 PDT 2011


Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 33247: Upwards cursor movement incorrect when previous block ends with <br>
https://bugs.webkit.org/show_bug.cgi?id=33247

Attachment 103120: rebaselined the test
https://bugs.webkit.org/attachment.cgi?id=103120&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103120&action=review


> LayoutTests/editing/execCommand/move-selection-back-line-rtl.html:6
> +<p>Move the caret from [ ] in the second line to [ ] in the first line.</p>

It would be nice if this description were more specific like the old test
description (what to do and what should happen).

> LayoutTests/editing/execCommand/move-selection-back-line-strict.html:1
> +<div contentEditable="true" style="font-family: monospace;">

Did you mean to add a <!DOCTYPE html> here?


More information about the webkit-reviews mailing list