[webkit-reviews] review denied: [Bug 64879] [Qt] Implement WebGL antialiasing (part 3) : [Attachment 103107] implement antialiasing

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 64879: [Qt] Implement WebGL antialiasing (part 3)
https://bugs.webkit.org/show_bug.cgi?id=64879

Attachment 103107: implement antialiasing
https://bugs.webkit.org/attachment.cgi?id=103107&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103107&action=review


> Source/WebCore/ChangeLog:11
> +	   Implement WebGL antialiasing for Qt.
> +	   Requires adoption of Extensions3DOpenGL to be functional.

Please explain concisely what this would do, how we're using existing code for
antialiasing, and what your new patch does.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:79
> +    void multisampleResolve() const;

Maybe a more descriptive name? something like blitMultisampleFboToMainFbo? (you
can choose a better name).
"Resolve" sounds a bit too close to resolving GL function names, even though
it's a technically accurate term.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:154
> +	   if (currentContext) {
> +	       if (currentContext != widgetContext)
> +		   const_cast<QGLContext*>(currentContext)->makeCurrent();
> +	   } else
> +	       m_glWidget->doneCurrent();
> +    }
> +

Please add a comment (e.g. // switch to the FBO's context for resolving
multisamples)