[webkit-reviews] review denied: [Bug 64879] [Qt] Implement WebGL antialiasing (part 3) : [Attachment 103106] adopt Extensions3DOpenGL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 5 14:05:28 PDT 2011


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 64879: [Qt] Implement WebGL antialiasing (part 3)
https://bugs.webkit.org/show_bug.cgi?id=64879

Attachment 103106: adopt Extensions3DOpenGL
https://bugs.webkit.org/attachment.cgi?id=103106&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103106&action=review


Code is good, Changelog needs to be a lot more descriptive. In particular the
differences between how we handle ES and desktop. Don't be afraid to repeat
yourself.

> Source/WebCore/ChangeLog:10
> +	   Adopt Extensions3DOpenGL for Qt antialiasing support.

Insufficient. We're doing things differently for ES and desktop - please
describe it in the changelog.


More information about the webkit-reviews mailing list