[webkit-reviews] review denied: [Bug 65722] Wrong code in RenderText::absoluteQuadsForRange() : [Attachment 103101] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 5 13:51:36 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 65722: Wrong code in RenderText::absoluteQuadsForRange()
https://bugs.webkit.org/show_bug.cgi?id=65722

Attachment 103101: Patch
https://bugs.webkit.org/attachment.cgi?id=103101&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
Not sure this is right. quadForTextBox() calls selectionRect(), which uses
selectionRectForRepaint(). The 'for repaint' indicates that it's already been
converted to the coordinate system of the repaintContainer (or the root).

If there aren't repaint tests for this code, you should make some.


More information about the webkit-reviews mailing list