[webkit-reviews] review denied: [Bug 65088] Intel Compiler on windows fails to build : [Attachment 102469] Fix building with Intel Compiler on Windows with Qt

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Aron Rosenberg
<arosenberg at logitech.com>'s request for review:
Bug 65088: Intel Compiler on windows fails to build
https://bugs.webkit.org/show_bug.cgi?id=65088

Attachment 102469: Fix building with Intel Compiler on Windows with Qt
https://bugs.webkit.org/attachment.cgi?id=102469&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102469&action=review


> ChangeLog:4
> +
> +	   Reviewed by Yael Aharon.
> +

Uh???

> Source/JavaScriptCore/wtf/ByteArray.h:94
> +#if COMPILER(MSVC) && !COMPILER(INTEL)

You mean COMPILER(MSVC) is true for the Intel compiler??? That is really weird.


> Source/JavaScriptCore/wtf/NullPtr.h:38
> +#if __has_feature(cxx_nullptr) || (GCC_VERSION_AT_LEAST(4, 6, 0) &&
defined(__GXX_EXPERIMENTAL_CXX0X__)) || (defined(_MSC_VER) && _MSC_VER >= 1600
&& !COMPILER(INTEL))

The AND make the whole line harder to read and look suspicious.
Why not || !COMPILER(INTEL)?

> Source/WebKit.pri:160
> +win32-icc: QMAKE_CXXFLAGS += -wd873

You must add an explanation for this in the changelog.