[webkit-reviews] review requested: [Bug 65330] Remove auth-related functions from SubresourceLoaderClient : [Attachment 103077] Remove receivedCancellation()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 5 09:28:34 PDT 2011
Nate Chapin <japhet at chromium.org> has asked for review:
Bug 65330: Remove auth-related functions from SubresourceLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=65330
Attachment 103077: Remove receivedCancellation()
https://bugs.webkit.org/attachment.cgi?id=103077&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
After some more studying, it appears receivedCancellation() doesn't actually do
anything in any SubresourceLoaderClient. Keep in mind that it's always
followed by a didFail() because ResourceLoader::receivedCancellation() cancels
the load. didFail() and receivedCancellation() do the same thing in both
WorkerScriptLoader and Notification. In XMLHttpRequest, receivedCancellation()
just sets m_response, and didFail() clears m_response before using it in any
way.
More information about the webkit-reviews
mailing list