[webkit-reviews] review granted: [Bug 65612] Web Inspector: draft implementation of source mapping listeners. : [Attachment 102910] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 65612: Web Inspector: draft implementation of source mapping listeners.
https://bugs.webkit.org/show_bug.cgi?id=65612

Attachment 102910: Patch
https://bugs.webkit.org/attachment.cgi?id=102910&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102910&action=review


> Source/WebCore/inspector/front-end/EventListenersSidebarPane.js:240
> +	       var url = this.eventListener.location.scriptId;

Please add yet another FIXME on the location structure + use of column.

> Source/WebCore/inspector/front-end/ProfileDataGridTree.js:101
> +	       var urlElement =
WebInspector.debuggerPresentationModel.linkifyLocation(this.profileNode.url,
lineNumber, 0, "profile-node-file");

Do you know what url is?

> Source/WebCore/inspector/front-end/TimelinePanel.js:1128
> +		       return this._linkifyLocation(this.stackTrace[0].url,
this.stackTrace[0].lineNumber, this.stackTrace[0].columnNumber);

Extract method receiving ConsoleCallFrame