[webkit-reviews] review granted: [Bug 65328] [Qt] QtTestBrowser: add support for saving cookies on disk : [Attachment 102965] patch v4 (fixex from Kling's review + fix for a race in the destructor)

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Ademar Reis
<ademar.reis at openbossa.org>'s request for review:
Bug 65328: [Qt] QtTestBrowser: add support for saving cookies on disk
https://bugs.webkit.org/show_bug.cgi?id=65328

Attachment 102965: patch v4 (fixex from Kling's review + fix for a race in the
destructor)
https://bugs.webkit.org/attachment.cgi?id=102965&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102965&action=review


Kool!

> Tools/QtTestBrowser/cookiejar.cpp:90
> +    foreach (const QNetworkCookie cookie, cookies) {

Iterator should be a const-reference :)

> Tools/QtTestBrowser/cookiejar.cpp:102
> +	   foreach (const QByteArray cookie, m_rawCookies)

Ditto.