[webkit-reviews] review denied: [Bug 62619] Implement <input type=color> UI behavior WebCore part : [Attachment 103057] new fixed patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 62619: Implement <input type=color> UI behavior WebCore part
https://bugs.webkit.org/show_bug.cgi?id=62619

Attachment 103057: new fixed patch
https://bugs.webkit.org/attachment.cgi?id=103057&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103057&action=review


> Source/WebCore/html/HTMLInputElement.cpp:890
> +#if ENABLE(INPUT_COLOR)
> +    if (ColorChooser::chooser()->client() == m_inputType) {
> +	   if (m_inputType->isColorControl) {
> +	       if (Page* page = frame->page())
> +		   page->chrome()->closeColorChooser();
> +	   }
> +    }
> +#endif

We should not add type-specific code into HTMLInputElement.
Please add InputType::elementWasDetached().

> Source/WebCore/platform/ColorChooser.h:46
> +    virtual void closeColorChooserIfClientInDocument(Document*) = 0;

IfClientInDocument -> IfClientIsInDocument