[webkit-reviews] review granted: [Bug 65744] Remove LegacyDefaultOptionalArguments flag from storage IDL files : [Attachment 103032] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 65744: Remove LegacyDefaultOptionalArguments flag from storage IDL files
https://bugs.webkit.org/show_bug.cgi?id=65744

Attachment 103032: Patch
https://bugs.webkit.org/attachment.cgi?id=103032&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103032&action=review


> Source/WebCore/storage/StorageInfo.idl:41
> -	   [CallWith=ScriptExecutionContext] void queryUsageAndQuota(in
unsigned short storageType, in [Callback, Optional] StorageInfoUsageCallback
usageCallback, in [Callback, Optional] StorageInfoErrorCallback errorCallback);

> -	   [CallWith=ScriptExecutionContext] void requestQuota(in unsigned
short storageType, in unsigned long long newQuotaInBytes, in [Callback,
Optional] StorageInfoQuotaCallback quotaCallback, in [Callback, Optional]
StorageInfoErrorCallback errorCallback);
> +	   [CallWith=ScriptExecutionContext] void queryUsageAndQuota(in
[Optional=CallWithDefaultValue] unsigned short storageType, 
> +								     in
[Callback, Optional] StorageInfoUsageCallback usageCallback, 
> +								     in
[Callback, Optional] StorageInfoErrorCallback errorCallback);
> +	   [CallWith=ScriptExecutionContext] void requestQuota(in
[Optional=CallWithDefaultValue] unsigned short storageType, 
> +							       in
[Optional=CallWithDefaultValue] unsigned long long newQuotaInBytes, 
> +							       in [Callback,
Optional] StorageInfoQuotaCallback quotaCallback, 
> +							       in [Callback,
Optional] StorageInfoErrorCallback errorCallback);

QUOTA is very new.  I wouldn't add the optional attributes.