[webkit-reviews] review granted: [Bug 65737] Remove LegacyDefaultOptionalArguments flag from canvas IDL files : [Attachment 103021] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 4 19:00:37 PDT 2011


Adam Barth <abarth at webkit.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 65737: Remove LegacyDefaultOptionalArguments flag from canvas IDL files
https://bugs.webkit.org/show_bug.cgi?id=65737

Attachment 103021: Patch
https://bugs.webkit.org/attachment.cgi?id=103021&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103021&action=review


> Source/WebCore/html/canvas/OESVertexArrayObject.idl:38
> -	   [StrictTypeChecking] void	     deleteVertexArrayOES(in
WebGLVertexArrayObjectOES arrayObject);
> -	   [StrictTypeChecking] boolean      isVertexArrayOES(in
WebGLVertexArrayObjectOES arrayObject);
> -	   [StrictTypeChecking] void	     bindVertexArrayOES(in
WebGLVertexArrayObjectOES arrayObject) raises(DOMException);
> +	   [StrictTypeChecking] void	     deleteVertexArrayOES(in
[Optional=CallWithDefaultValue] WebGLVertexArrayObjectOES arrayObject);
> +	   [StrictTypeChecking] boolean      isVertexArrayOES(in
[Optional=CallWithDefaultValue] WebGLVertexArrayObjectOES arrayObject);
> +	   [StrictTypeChecking] void	     bindVertexArrayOES(in
[Optional=CallWithDefaultValue] WebGLVertexArrayObjectOES arrayObject)
raises(DOMException);

Is there any bad interaction between StrictTypeChecking and
CallWithDefaultValue?


More information about the webkit-reviews mailing list