[webkit-reviews] review granted: [Bug 64628] Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d : [Attachment 103017] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 64628: Remove LegacyDefaultOptionalArguments flag from
CanvasRenderingContext2d
https://bugs.webkit.org/show_bug.cgi?id=64628

Attachment 103017: Patch
https://bugs.webkit.org/attachment.cgi?id=103017&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103017&action=review


> Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:212
> +	   void drawImageFromRect(in HTMLImageElement image,
>							       in [Optional]
float sx, in [Optional] float sy, in [Optional] float sw, in [Optional] float
sh,
>							       in [Optional]
float dx, in [Optional] float dy, in [Optional] float dw, in [Optional] float
dh,
>							       in [Optional]
DOMString compositeOperation);

Maybe re-indent the rest of the arguments?

> Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:238
> -	   void setShadow(in float width, in float height, in float blur, in
[Optional] DOMString color, in [Optional] float alpha);
> -	   void setShadow(in float width, in float height, in float blur, in
float grayLevel, in [Optional] float alpha);
> -	   void setShadow(in float width, in float height, in float blur, in
float r, in float g, in float b, in float a);
> -	   void setShadow(in float width, in float height, in float blur, in
float c, in float m, in float y, in float k, in float a);
> +	   void setShadow(in float width, 
> +			  in float height, 
> +			  in float blur, 
> +			  in [Optional] DOMString color, 
> +			  in [Optional] float alpha);
> +	   void setShadow(in float width, 
> +			  in float height, 
> +			  in float blur, 
> +			  in float grayLevel, 
> +			  in [Optional] float alpha);
> +	   void setShadow(in float width, 
> +			  in float height, 
> +			  in float blur, 
> +			  in float r, 
> +			  in float g, 
> +			  in float b, 
> +			  in float a);
> +	   void setShadow(in float width, 
> +			  in float height, 
> +			  in float blur, 
> +			  in float c, 
> +			  in float m, 
> +			  in float y, 
> +			  in float k, 
> +			  in float a);

Not optional?