[webkit-reviews] review granted: [Bug 65720] Add code to determine whether a Range in inside fixed position content : [Attachment 103010] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 65720: Add code to determine whether a Range in inside fixed position
content
https://bugs.webkit.org/show_bug.cgi?id=65720

Attachment 103010: Patch
https://bugs.webkit.org/attachment.cgi?id=103010&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103010&action=review


> Source/WebCore/rendering/RenderBlock.h:653
> +    virtual void absoluteQuads(Vector<FloatQuad>&, bool*);

This bool should have a parameter name.

> Source/WebCore/rendering/RenderBox.h:231
> +    virtual void absoluteQuads(Vector<FloatQuad>&, bool*);

This bool should have a parameter name.

> Source/WebCore/rendering/RenderInline.h:50
> +    virtual void absoluteQuads(Vector<FloatQuad>&, bool*);

This bool should have a parameter name.

> Source/WebCore/rendering/svg/RenderSVGModelObject.h:59
> +    virtual void absoluteQuads(Vector<FloatQuad>&, bool*);

This bool should have a parameter name.

> Source/WebCore/rendering/svg/RenderSVGText.h:63
> +    virtual void absoluteQuads(Vector<FloatQuad>&, bool*);

This bool should have a parameter name.