[webkit-reviews] review denied: [Bug 65708] Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState : [Attachment 102994] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 65708: Logic to compute visible display rect in
GraphicsLayerCA::syncCompositingState
https://bugs.webkit.org/show_bug.cgi?id=65708

Attachment 102994: Patch
https://bugs.webkit.org/attachment.cgi?id=102994&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102994&action=review


> Source/WebCore/ChangeLog:6
> +	   This is in support of <rdar://problem/9706222> and
<rdar://problem/9434765>

No need to mention radar numbers.

> Source/WebCore/page/FrameView.cpp:709
> +	       fullScreenLayer->syncCompositingState(frameRect());

Please add a comment that this only works on platforms where RLC uses a scroll
layer.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:831
> +void GraphicsLayerCA::recursiveCommitChanges(TransformState& state, float
pageScaleFactor, const FloatPoint& positionRelativeToBase, bool
affectedByPageScale)
>  {
> +    TransformState::TransformAccumulation accumulation = preserves3D() ?
TransformState::AccumulateTransform : TransformState::FlattenTransform;
> +    state.move(m_position.x(), m_position.y(), accumulation);

This code needs to maintain stack of TransformStates, otherwise your state is
wrong when you come back out of children.