[webkit-reviews] review requested: [Bug 65723] A few purely stylistic modifications to visible_units.cpp : [Attachment 102988] Proposed fix

[bugzilla-daemon at webkit.org]

Van Lam <vanlam at google.com> has asked  for review:
Bug 65723: A few purely stylistic modifications to visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=65723

Attachment 102988: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=102988&action=review

------- Additional Comments from Van Lam <vanlam at google.com>
Renamed greatestValueUnder to greatestOffsetUnder, positionIsInsideBox to
positionIsInBoxButNotOnBoundary (to avoid confusion with positionIsInBox, which
is just a getInlineBoxAndOffset check).
Removed use of invalidOffset as an error value in greatestOffsetUnder and
smallestOffsetAbove since semantically it should only be used to check if it
makes sense to compare offsets in a single box.