[webkit-reviews] review granted: [Bug 65717] Remove LegacyDefaultOptionalArguments flag from Document.idl : [Attachment 102979] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 65717: Remove LegacyDefaultOptionalArguments flag from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65717

Attachment 102979: Patch
https://bugs.webkit.org/attachment.cgi?id=102979&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102979&action=review


> Source/WebCore/dom/Document.idl:46
> -	   [ReturnsNew] EntityReference createEntityReference(in DOMString
name)
> +	   [ReturnsNew] EntityReference createEntityReference(in
[Optional=CallWithDefaultValue] DOMString name)

Crazy.	I have no idea what ReturnsNew means.

> Source/WebCore/dom/Document.idl:332
> +	   [ReturnsNew, EnabledAtRuntime] Touch createTouch(in
[Optional=CallWithDefaultValue] DOMWindow window,
> +							    in
[Optional=CallWithDefaultValue] EventTarget target,
> +							    in
[Optional=CallWithDefaultValue] long identifier,
> +							    in
[Optional=CallWithDefaultValue] long pageX,
> +							    in
[Optional=CallWithDefaultValue] long pageY,
> +							    in
[Optional=CallWithDefaultValue] long screenX,
> +							    in
[Optional=CallWithDefaultValue] long screenY,
> +							    in
[Optional=CallWithDefaultValue] long webkitRadiusX,
> +							    in
[Optional=CallWithDefaultValue] long webkitRadiusY,
> +							    in
[Optional=CallWithDefaultValue] float webkitRotationAngle,
> +							    in
[Optional=CallWithDefaultValue] float webkitForce)

This API seems poorly designed, but that's another story.  What does it mean to
have prefixed argument names?