[webkit-reviews] review granted: [Bug 65715] Remove LegacyDefaultOptionalArguments flag from DOM-related files except Document.idl : [Attachment 102972] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 65715: Remove LegacyDefaultOptionalArguments flag from DOM-related files
except Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65715

Attachment 102972: Patch
https://bugs.webkit.org/attachment.cgi?id=102972&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102972&action=review


> Source/WebCore/dom/Clipboard.idl:-32
> -	   LegacyDefaultOptionalArguments,

is RequiresAllArguments still needed for setData ?

> Source/WebCore/dom/MediaStreamList.idl:31
> -	   MediaStream item(in [IsIndex] unsigned long index);
> +	   MediaStream item(in [IsIndex,Optional=CallWithDefaultValue] unsigned
long index);

I'm slightly unsure about this one.  The MediaStream stuff is very new, so
maybe it doesn't need it?  On the other hand, having all these fake vectors be
consistent seems beneficial.

> Source/WebCore/dom/MediaStreamTrackList.idl:31
> -	   MediaStreamTrack item(in [IsIndex] unsigned long index);
> +	   MediaStreamTrack item(in [IsIndex,Optional=CallWithDefaultValue]
unsigned long index);

This probably isn't needed.