[webkit-reviews] review granted: [Bug 65688] [Chromium] Reduce memory consumption of HarfbuzzFace : [Attachment 102939] Patch V1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 4 12:05:16 PDT 2011


Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 65688: [Chromium] Reduce memory consumption of HarfbuzzFace
https://bugs.webkit.org/show_bug.cgi?id=65688

Attachment 102939: Patch V1
https://bugs.webkit.org/attachment.cgi?id=102939&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102939&action=review


> Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp:231
> +typedef HashMap<unsigned int, FaceCacheEntry, WTF::IntHash<unsigned int>,
WTF::UnsignedWithZeroKeyHashTraits<unsigned int> > HarfbuzzFaceCache;

Nit: If you use |unsigned| instead of |unsigned int|, can you drop the last 2
template parameters?


More information about the webkit-reviews mailing list