[webkit-reviews] review denied: [Bug 65611] Add firstPartyOrigin parameter to WebStorageNamespace::createStorageArea : [Attachment 102881] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Marja Hölttä
<marja at chromium.org>'s request for review:
Bug 65611: Add firstPartyOrigin parameter to
WebStorageNamespace::createStorageArea
https://bugs.webkit.org/show_bug.cgi?id=65611

Attachment 102881: Patch
https://bugs.webkit.org/attachment.cgi?id=102881&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102881&action=review


> Source/WebKit/chromium/public/WebStorageNamespace.h:71
> +    virtual WebStorageArea* createStorageArea(const WebString& origin, const
WebString& firstPartyOrigin);

i think it would make sense to switch over to passing WebSecurityOrigin instead
of WebString.
it is often better to expose WebSecurityOrigin instead of raw strings.	when
createStorageArea
was first created, we probably didn't yet have WebSecurityOrigin or the
discipline to pass it
around instead of raw strings.